Undo Send zimlet Zimbra OS 8.0.1 - hitting Send button not responding

[marvin42]

Hi!

I've just deployed Undo Send zimlet, and after activating, on the web client the hitting the Send button not responding.

If I drop down the button and then hit Send, it sends immediately, so I guess Undo Send is not involved/triggered.
Also, Send later works fine.

I've loved and used this Zimlet with Zimbra OS 6.x and 7.x without any problem.

Do anyone has this issue, or can anyone reproduce it?

Marvin

p.s.: if it matters, I've moved from 7.x to 8.0.1 by ZExtras Migration toolkit, to a different OS and domain.

[liudongmiao]

i write a patch for it, now it works for me in "compose" tab or new "window".
however, it doesnt works when reply in the "mail" tab.

here is the package: https://piebridge.me/com_zimbra_undosend.zip

diff -urp old/undosend.js new/undosend.js
--- old/undosend.js	2011-08-23 07:37:28.000000000 +0800
+++ new/undosend.js	2013-01-13 03:40:49.000000000 +0800
@@ -101,12 +101,18 @@ function(controller) {
 	if (!this.appViewMgr) {
 		this.appViewMgr = appCtxt.getAppViewMgr();
 	}	
-	var viewId = this.appViewMgr._currentView;
+	var viewId = this.appViewMgr._currentView || this.appViewMgr._currentViewId;
 
 	if(!appCtxt.isChildWindow) {
-		if (this.appViewMgr._isTabView[viewId]) {
+		if (this.appViewMgr._isTabView && this.appViewMgr._isTabView[viewId]) {
 			var tab = appCtxt.getAppChooser().getButton(this.appViewMgr._tabParams[viewId].id);
 			var title = this._getComposeTabTitle(viewId);//store the title as when we push the view back, it doesnt seem to work
+		} else if (this.appViewMgr._view && this.appViewMgr._view[viewId].isTabView) {
+			var tab = appCtxt.getAppChooser().getButton(this.appViewMgr._view[viewId].tabParams.id);
+			var title = this._getComposeTabTitle(viewId);//store the title as when we push the view back, it doesnt seem to work
+		} else {
+			var tab = undefined;
+			var title = this._getComposeTabTitle(viewId);//store the title as when we push the view back, it doesnt seem to work
 		}
 	}
 	var undoLinkId = "UndoSendHdlrZimlet_undoLink" + viewId;

Hi!

I've just deployed Undo Send zimlet, and after activating, on the web client the hitting the Send button not responding.

If I drop down the button and then hit Send, it sends immediately, so I guess Undo Send is not involved/triggered.
Also, Send later works fine.

I've loved and used this Zimlet with Zimbra OS 6.x and 7.x without any problem.

Do anyone has this issue, or can anyone reproduce it?

Marvin

p.s.: if it matters, I've moved from 7.x to 8.0.1 by ZExtras Migration toolkit, to a different OS and domain.