zimbra_posixaccount Admin Extension

[pbruna]

We found a problem with setting up the groups trough this extension.
The problem is cosmetic and non functional.
Cosmetic beacuse the UI ask for the Number UID when entering the members of the group, i think is easier to remember the usernames

And is non functional because, in red hat at least, when you work with groups you need to enter the NAME no the uid number. This way the system resolve which are the members of the group.

The UI extension does not let you enter text (the name of the users), only numbers in the member field, so i modified the file to let you enter the name, so everything works (for us at least).

The file is: /opt/zimbra/tomcat/webapps/service/zimlet/zimbra_posixaccount/ZaPosixGroup.js


i changed the line 315:

code:
{id:ZaPosixGroup.A_memberUid, type:_LIST_, ref:"attrs/"+ZaPosixGroup.A_memberUid, listItem:{type:_NUMBER_}}


with:

code
{id:ZaPosixGroup.A_memberUid, type:_LIST_, ref:"attrs/"+ZaPosixGroup.A_memberUid, listItem:{type:_STRING_}}

Also i had to change the File: /opt/zimbra/tomcat/webapps/service/zimlet/zimbra_posixaccount/ZaPosixGroupXFormView.js

the line 139:

{ref:".", type:_TEXTFIELD_, label:null, onChange:ZaTabView.onFormFieldChanged,cssClass:"ad min_xform_number_input"}

with:

{ref:".", type:_TEXTFIELD_, label:null, onChange:ZaTabView.onFormFieldChanged,cssClass:"ad min_xform_name_input"}

The problem with this last change is when i create a group with only 1 member and then i try to edit the group, Zimbra takes the name and split it by letters, so show every letter of the name as a member of the group.

I hope Greg could tell me why.

[Greg]

Originally Posted by pbruna

/opt/zimbra/tomcat/webapps/service/zimlet/zimbra_posixaccount/ZaPosixGroup.js

i changed the line 315:

/opt/zimbra/tomcat/webapps/service/zimlet/zimbra_posixaccount/ZaPosixGroup.js

with:

/opt/zimbra/tomcat/webapps/service/zimlet/zimbra_posixaccount/ZaPosixGroup.js

Do you mean that you changed

{id:ZaPosixGroup.A_memberUid, type:_LIST_, ref:"attrs/"+ZaPosixGroup.A_memberUid, listItem:{type:_NUMBER_}}

with

{id:ZaPosixGroup.A_memberUid, type:_LIST_, ref:"attrs/"+ZaPosixGroup.A_memberUid, listItem:{type:_STRING_}}

Anyway, I think I know what the problem is, please open a bug in bugzilla and CC me on this bug (my id in bugzilla is greg '@' zimbra - dot - com

[pbruna]

Greg,
You are correct.

[Greg]

Try this, add

	
if(this.attrs && this.attrs[ZaPosixGroup.A_memberUid] && !(this.attrs[ZaPosixGroup.A_memberUid] instanceof Array))
		this.attrs[ZaPosixGroup.A_memberUid] = [this.attrs[ZaPosixGroup.A_memberUid]];

to the end of

ZaPosixGroup.prototype.initFromJS

method, resulting code should be this:

ZaPosixGroup.prototype.initFromJS = function(posixGroup) {
	ZaItem.prototype.initFromJS.call(this, posixGroup);

	if(this.attrs && this.attrs[ZaPosixGroup.A_gidNumber])
		this.id = this.attrs[ZaPosixGroup.A_gidNumber];
		
	if(!this.name && this.attrs && this.attrs[ZaPosixGroup.A_cn])
		this.name = this.attrs[ZaPosixGroup.A_cn];

	if(this.attrs && this.attrs[ZaPosixGroup.A_memberUid] && !(this.attrs[ZaPosixGroup.A_memberUid] instanceof Array))
		this.attrs[ZaPosixGroup.A_memberUid] = [this.attrs[ZaPosixGroup.A_memberUid]];
}

instead of this:

ZaPosixGroup.prototype.initFromJS = function(posixGroup) {
	ZaItem.prototype.initFromJS.call(this, posixGroup);
	
	if(this.attrs && this.attrs[ZaPosixGroup.A_gidNumber])
		this.id = this.attrs[ZaPosixGroup.A_gidNumber];
		
	if(!this.name && this.attrs && this.attrs[ZaPosixGroup.A_cn])
		this.name = this.attrs[ZaPosixGroup.A_cn];

}

[pbruna]

Greg,
Thanks a lot, it worked perfectly.